Support bigger seed.sql files using docker copy #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For seed.sql files that exceed the maximum argument length of the Linux distribution used to run the Postgres container the postgres -c command will fail. Supabase CLI will then silently fail to apply the seed file. A new Docker utility function DockerAddFile can be used to write a byte buffer to a container, in this case the seed.sql file. Then migrating the seed file is just a matter of using the file option of the pgsql command rather than the command option. Signed-off-by: Snorre Magnus Davøen <post@snorre.io>
Signed-off-by: Snorre Magnus Davøen <post@snorre.io>
snorremd
changed the title
|
LGTM, thanks for this! |
soedirgo
approved these changes
Jul 4, 2022
|
🎉 This PR is included in version 0.28.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
My pleasure. Thank you for reviewing and merging this so fast! This will improve my development flow so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
For seed.sql files that exceed the maximum argument length of the Linux distribution used to run the Postgres container the
postgres -ccommand will fail. Supabase CLI will then silently fail to apply the seed file.See related StackOverflow Max size of string CMD that can be passed to Docker answer about command argument sizes.
#277 (See related comment)
#274 (I think this might be related, but not sure)
What is the new behavior?
A new Docker utility function DockerAddFile can be used to write a byte buffer to a container, in this case the seed.sql file. Then migrating the seed file is just a matter of using the file option of the
pgsqlcommand rather than the command option.Additional context
Let me know if the code needs some adjustments and if the selected approach is good or not.