Fix Button and IconButton RSC compatibility #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 167a8e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2982 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 229 229
Lines 13082 13082
Branches 1764 1764
=======================================
Hits 11464 11464
Misses 1561 1561
Partials 57 57
🚀 New features to boost your workflow:
|
|
Size Change: +14 B (0%) Total Size: 707 kB
ℹ️ View Unchanged
|
sirineJ
approved these changes
Mar 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We received a report that the Button component throws an error when rendered inside a React Server Component (RSC). I discovered that it and the IconButton component are missing the
'use client'directive. It should have been added automatically byeslint-plugin-react-server-components, I suspect that didn't happen because thecreateButtonComponentfactory function abstracts away the client logic.Approach and changes
'use client'directive to the Button and IconButton componentsDefinition of done