Hide close button for Popover #2977
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Given that the close button is an accessibility requirement, especially on mobile, I vote to keep it by default. Perhaps we can expose the |
|
Size Change: +18 B (0%) Total Size: 684 kB
ℹ️ View Unchanged
|
🚀 Your packages were publishedPublished Packages:
|
🚀 Your packages were publishedPublished Packages:
|
sirineJ
force-pushed
the
hide-close-button-popover
branch
from
c837479 to
2350136
Compare
🚀 Your packages were publishedPublished Packages:
|
sirineJ
force-pushed
the
hide-close-button-popover
branch
from
4eb5d1e to
e09e8ad
Compare
🚀 Your packages were publishedPublished Packages:
|
sirineJ
force-pushed
the
hide-close-button-popover
branch
from
e09e8ad to
957991b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2977 +/- ##
==========================================
+ Coverage 89.86% 89.93% +0.07%
==========================================
Files 226 220 -6
Lines 13717 13526 -191
Branches 1816 1816
==========================================
- Hits 12327 12165 -162
+ Misses 1369 1340 -29
Partials 21 21
|
🚀 Your packages were publishedPublished Packages:
|
🚀 Your packages were publishedPublished Packages:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
After merging #2903 a closed button appeared on the Popover component.
Approach and changes
Add
hideCloseButtonprop to the dialog inside the Popover componentDefinition of done