Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete ESLint rules #2976

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

Conversation

connor-baer
Copy link
Member

Purpose

There are several ESLint rules for code that has long been removed or will be removed in v10. Keeping them around just increases lint times unnecessarily.

Approach and changes

  • Remove obsolete configs from the component-lifecycle-imports, no-renamed-props, and renamed-package-scope rules
  • Remove the obsolete no-deprecated-components and renamed-package-scope rules

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner March 3, 2025 15:18
@connor-baer connor-baer requested a review from sirineJ March 3, 2025 15:18
Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: 40a6349

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ❌ Failed (Inspect) Mar 3, 2025 3:21pm

@connor-baer
Copy link
Member Author

The linter is failing because Foundry references some of the removed rules. I'll create a separate PR to update Foundry to be merged into this one before merging everything to next.

@connor-baer connor-baer added the ⛔ do not merge There is a blocker label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants