Adapt Calendar component for Node v22.12+ #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 65e5d00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -14 B (0%) Total Size: 670 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2832 +/- ##
==========================================
- Coverage 87.90% 87.90% -0.01%
==========================================
Files 218 218
Lines 12726 12722 -4
Branches 1727 1727
==========================================
- Hits 11187 11183 -4
Misses 1487 1487
Partials 52 52
|
sirineJ
approved these changes
Dec 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Node v22.12 broke the Calendar component's unit tests because the month headline changed from e.g. "March 2020" to "2020 March". Node v22.12 updated the ICU data to v76.1 which included the Common Locale Data Repository (CLDR) v46. We were impacted by this specific change:
The Temporal API uses the
iso8601calendar by default since it covers dates before 1582 and "is the system most often used in computing, on the modern Internet" (ref). I believe we should stick with this default since migrating from theiso8601to thegregorycalendar would be a breaking change and increase boilerplate code for developers.Approach and changes
gregorycalendar for formatting.calendarprop since support for thegregorycalendar system wasn't fully tested and is partially broken. The prop should be removed in the next major version.Definition of done