Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation #81

Merged
merged 54 commits into from
Jan 20, 2022
Merged

Keyboard navigation #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
16fbac7
feat(dateinput): Convert span to button
mst101 Aug 6, 2021
36192b2
feat(pickers): Extract UpButton.vue & convert span to button
mst101 Aug 6, 2021
8bb136d
feat(pickercells): Convert span to button
mst101 Aug 6, 2021
49d5f38
feat(datepicker): Remove superfluous selected-disabled event
mst101 Aug 6, 2021
4e910e2
feat(pickers): Let pickers know the open date
mst101 Aug 1, 2021
a5b7e1b
feat(pickers): Let pickerMonth/Year know today's date
mst101 Jul 25, 2021
c258696
test(e2e): Add data-test attributes
mst101 Aug 6, 2021
8e02f3b
feat(dateinput): Don't close calendar on input blur
mst101 Aug 6, 2021
f26a376
feat(datepicker): Determine which cell is tabbable initially
mst101 Jul 29, 2021
5bbf131
feat(datepicker): Build an array of navElements to focus trap
mst101 Aug 10, 2021
f04ecf0
feat(datepicker): Tab through focus-trapped navElements
mst101 Jul 30, 2021
22ebd1d
feat(datepicker): Focus correct element on open
mst101 Aug 10, 2021
4931fa2
feat(datepicker): Focus prev/next buttons on click
mst101 Aug 10, 2021
824f711
feat(datepicker): Keep track of tabbable-cell
mst101 Aug 5, 2021
4154a72
feat(datepicker): Focus correct element on view change
mst101 Aug 10, 2021
150d72c
feat(datepicker): Close on losing focus
mst101 Aug 10, 2021
1a1d3aa
feat(dateinput): Only validate typed date on blur/enter
mst101 Aug 10, 2021
e483f0d
fix(datepicker): Set typed date to null if zero length
mst101 Aug 9, 2021
566e188
refactor(dateinput): Rewrite isFocusedUsed as shouldToggleOnClick/Focus
mst101 Aug 10, 2021
8807c91
feat(datepicker): Focus correct element on close
mst101 Aug 10, 2021
7c26eb3
feat(datepicker): Revert to open date/close on escape
mst101 Aug 6, 2021
da51292
feat(pickerheader): Arrow keys on prev/up/next buttons
mst101 Aug 10, 2021
6bf523e
test(datepicker): Only set initial view if open
mst101 Aug 10, 2021
50240be
feat(dateinput): Toggle via space bar
mst101 Aug 10, 2021
0fa129a
feat(dateinput): Arrow down from input
mst101 Aug 10, 2021
26d29ee
feat(pickercells): Handle arrow keys
mst101 Aug 10, 2021
47bc71d
feat(datepicker): Update tabbable cell on focus change
mst101 Aug 1, 2021
55a23c0
feat(datepicker): Revert to open date/close on escape
mst101 Aug 10, 2021
074e359
feat(datepicker): Slide correct way on reverting to open date
mst101 Aug 3, 2021
186ca0f
feat(datepicker): Set correct transition on typed date
mst101 Aug 3, 2021
aedccf1
refactor(datepicker): Simplify unique id generation
mst101 Aug 27, 2021
53bd87e
refactor(datepicker): Blur activeElement
mst101 Sep 5, 2021
76b3dca
test(e2e): Fix minor linting issue
mst101 Sep 7, 2021
be0766a
refactor(datepicker): Use isClickOutside flag
mst101 Sep 7, 2021
9fc2a53
fix(style): Make focus outline pixel perfect
mst101 Sep 12, 2021
d61647c
fix(pickerheader): Stop disabled dates from closing calendar on next/…
mst101 Sep 10, 2021
42ece33
fix(datepicker): Set focus when open date is disabled
mst101 Sep 10, 2021
634a477
fix(datepicker): Focusable elements in slots
mst101 Sep 14, 2021
7e757e8
fix(datepicker): Focusable elements in before/afterDateInput slots
mst101 Jan 14, 2022
9d0f9c2
refactor(test): Simplify cell navigation test
mst101 Oct 4, 2021
b7228c6
refactor(pickermixin): Prefer use of HTMLButtonElement in JSDoc
mst101 Oct 7, 2021
f685891
fix(e2e): Select when NOT minimum view
mst101 Jan 14, 2022
515b4fc
fix(datepicker): Initial focus when opening calendar
mst101 Jan 14, 2022
540cb34
feat(datepicker): Set `isActive` when calendar is focused
mst101 Jan 15, 2022
52ad18a
feat(datepicker): Tabbing to/from an inline datepicker
mst101 Jan 15, 2022
fbc3b46
fix(datepicker): Focusable elements in `calendarFooter` slot
mst101 Jan 16, 2022
654654c
fix(datepicker): Refine which slot elements are focusable
mst101 Jan 16, 2022
fdac14e
refactor(navMixin): Order methods alphabetically
mst101 Jan 16, 2022
f640d24
chore(project): Update browserslist
mst101 Jan 16, 2022
328ad9c
chore(e2e): Upgrade Cypress to 9.2.1
mst101 Jan 16, 2022
11198cb
fix(datepicker): Arrow to page when destination & beyond disabled
mst101 Jan 17, 2022
fd12854
fix(dateinput): Check keystroke before parsing typed date
mst101 Jan 18, 2022
47cde8f
fix(demo): Remove `append-to-body` for fixed positions
mst101 Jan 18, 2022
e2ee8de
fix(datepicker): Resolve bug for when `append-to-body = true
mst101 Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/guide/Events/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@ These events are emitted on actions in the datepicker
| input | Date\|null | Input value has been modified |
| opened | | The picker has been opened |
| selected | Date\|null | A date has been selected |
| selected-disabled | Object | A disabled date has been selected |
| blur | | Input blur event |
| focus | | Input focus event |
2 changes: 1 addition & 1 deletion example-e2e/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<title>Vue.js Datepicker</title>
<link rel="stylesheet" type="text/css" href="styles/bootstrap.min.css">
</head>
<body>
<body data-test-body>
<div id="app"></div>
<script src="./app.js"></script>
</body>
Expand Down
2 changes: 1 addition & 1 deletion example/Demo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@

<div class="example">
<h3>Fixed positions</h3>
<Datepicker :fixed-position="fixedPosition" :append-to-body="true" />
<Datepicker :fixed-position="fixedPosition" />
<code>
&lt;datepicker :fixed-position="fixedPosition"&gt;&lt;/datepicker&gt;
</code>
Expand Down
2 changes: 1 addition & 1 deletion example/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />
<title>Vue.js Datepicker</title>
</head>
<body>
<body data-test-body>
<div id="app"></div>
<script src="./demo.js"></script>
</body>
Expand Down
51,185 changes: 6,324 additions & 44,861 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"@rollup/plugin-commonjs": "19.0.0",
"@rollup/plugin-node-resolve": "13.0.0",
"@rollup/plugin-replace": "2.4.2",
"@vue/cli-plugin-e2e-cypress": "4.5.13",
"@vue/cli-plugin-e2e-cypress": "4.5.15",
"@vue/eslint-config-prettier": "6.0.0",
"@vue/test-utils": "1.1.1",
"autoprefixer": "9.8.6",
Expand All @@ -75,7 +75,7 @@
"chalk": "4.1.1",
"cleave.js": "1.6.0",
"core-js": "3.12.1",
"cypress": "8.2.0",
"cypress": "9.2.1",
"cypress-cucumber-preprocessor": "4.1.4",
"cypress-plugin-tab": "1.0.5",
"date-fns": "2.21.3",
Expand All @@ -87,7 +87,7 @@
"eslint-import-resolver-webpack": "0.13.0",
"eslint-loader": "4.0.2",
"eslint-plugin-compat": "3.9.0",
"eslint-plugin-cypress": "2.11.3",
"eslint-plugin-cypress": "2.12.1",
"eslint-plugin-html": "6.1.2",
"eslint-plugin-import": "2.22.1",
"eslint-plugin-jest": "24.3.6",
Expand Down
Loading