Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds simple keyboard accessibility to toggle popup on enter, close with escape key #80

Closed
wants to merge 3 commits into from
Closed

Adds simple keyboard accessibility to toggle popup on enter, close with escape key #80

wants to merge 3 commits into from

Conversation

betweenbrain
Copy link

Hello,

We are working on implementing a more accessible version of this component and hope that we can contribute these changes back to your project.

Cheers!

@mst101
Copy link
Contributor

mst101 commented Feb 1, 2021

Hi @betweenbrain - I've also been working on this. In addition to the changes you've suggested, I'm planning to also allow for navigation via the arrow keys.

I've pretty much cracked that, but am struggling with issues related to the focus, in particular how to close the calendar when you click elsewhere on the page also how to prevent issues like #77.

I'll let you know once I've uploaded a clean version of my work-in-progress later today and would really appreciate it if you (and/or others) could have a look and offer your ideas. Thanks

@mst101
Copy link
Contributor

mst101 commented Feb 1, 2021

Please see #81.

@betweenbrain
Copy link
Author

I'm closing this PR as I am going to re-evaluate the approach for better backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants