Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing License #4479

Closed
wants to merge 7 commits into from
Closed

Conversation

Ashrafmuhmed
Copy link
Contributor

Description

This PR adds the AGPL-3.0 license headers to all JavaScript files in the project. This ensures compliance with the project's licensing requirements.

Changes

  • Added license headers to all .js files.
  • Updated ESLint configuration to enforce license headers.

Related Issues

Copy link

github-actions bot commented Mar 2, 2025

✅ All Jest tests passed! This PR is ready to merge.

@Ashrafmuhmed Ashrafmuhmed marked this pull request as ready for review March 2, 2025 13:51
@walterbender
Copy link
Member

Thanks for doing this, but there are a few problems.
(1) we should assign the copyright to the author of the file, not Music Blocks/Sugar Labs
(2) in many cases, you removed important context from the files (all of the files in API, for example
(3) there are many useful but unrelated changes that should be in a separate PR
(4) upstream config files that we are using don't need to be modified

@Ashrafmuhmed
Copy link
Contributor Author

Ashrafmuhmed commented Mar 2, 2025

Thank you for the feedback! I’ll work on fixing these points, but I have a few questions to clarify things further:

  1. Are you the author of most of the files in the project? If so, I can assign the copyright to you in the license headers.
  2. Regarding the unrelated changes, if you’re referring to the changes in the _() method, there’s already an open PR Refactor _() function to improve translation handling and case preservation #4476 for that. Could you please check it and let me know if there are any additional modifications you’d like?

Thanks for your guidance!

@walterbender
Copy link
Member

Let's focus for the moment on just the files in the test directories.
You can see whom is the original author by looking at the git commit logs.

@Ashrafmuhmed
Copy link
Contributor Author

Done #4482.

Whats is the next step ?

@walterbender
Copy link
Member

Let's revisit these changes in light of the updates to the test files.

@walterbender
Copy link
Member

Seems that the license text in js/SaveInterface.js, js/blocks/*js and js/js-export/API need updating. But be sure to keep the original author info. And please preserve the comments in the API headers that are unrelated to the license. Prob. a new PR makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing licenses
2 participants