Upgraded deprecated Gdk.color.parse to newer Gdk.color_parse #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Gdk.color.parse has been deprecated and Gdk.color_parse is the newer function to implement the functionality and I have changed
BlockParty.pyto use the newer function instead of the deprecated oneDescription
addressing #29 Gdk.color.parse has been deprecated since version 3.14 as mentioned here in the official Docs.
Gdk.color_parse achieves that functionality (check here)
The implementation is a little different though as we don't need to select any element from an array like we had to when using color.parse, we can simply use the returned value as the value returned is a Gdk.Color.