Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to use only Deno configuration #159

Merged
merged 6 commits into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/curvy-terms-march.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@suddenly-giovanni/schema-resume": patch
---

Completely migrated away from package.json
3 changes: 0 additions & 3 deletions .github/workflows/pull-request-checks-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,3 @@ jobs:
files: ./coverage/coverage-final.json
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

- name: 🦋 Require changesets
run: deno task changeset:status --since=origin/main
1 change: 0 additions & 1 deletion .npmrc

This file was deleted.

8 changes: 6 additions & 2 deletions deno.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"changeset:empty": {
"command": "changeset add --empty",
"description": "allows you to create an empty changeset if no packages are being bumped, usually only required if you have CI that blocks merges without a changeset."
"description": "Allows you to create an empty changeset if no packages are being bumped, usually only required if you have CI that blocks merges without a changeset."
},
"changeset:status": {
"command": "changeset status",
Expand All @@ -47,9 +47,13 @@
"command": "changeset version",
"description": "The version command takes changesets that have been made and updates versions and dependencies of packages, as well as writing changelogs. It is responsible for all file changes to versions before publishing to npm."
},
"test:all": "vitest"
"test:all": {
"command": "deno run -A --inspect npm:vitest@3.0.4",
"description": "Run all the project tests with vitest"
}
},
"imports": {
"@deno/vite-plugin": "npm:@deno/vite-plugin@1.0.2",
"@changesets/cli": "npm:@changesets/cli@2.27.12",
"@types/node": "npm:@types/node@22.10.10",
"@vitest/coverage-istanbul": "npm:@vitest/coverage-istanbul@3.0.4",
Expand Down
81 changes: 50 additions & 31 deletions deno.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 10 additions & 8 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

55 changes: 15 additions & 40 deletions flake.nix
Original file line number Diff line number Diff line change
@@ -1,47 +1,22 @@
{
description = "An empty flake template that you can adapt to your own environment";
description = "A flake for aarch64-darwin";

# Flake inputs
inputs.nixpkgs.url = "https://flakehub.com/f/NixOS/nixpkgs/*.tar.gz";
inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";

# Flake outputs
outputs = { self, nixpkgs }:
let
# The systems supported for this flake
supportedSystems = [
"x86_64-linux" # 64-bit Intel/AMD Linux
"aarch64-linux" # 64-bit ARM Linux
"x86_64-darwin" # 64-bit Intel macOS
"aarch64-darwin" # 64-bit ARM macOS
];

# Helper to provide system-specific attributes
forEachSupportedSystem = f: nixpkgs.lib.genAttrs supportedSystems (system: f {
pkgs = import nixpkgs { inherit system; };
});
in
{
devShells = forEachSupportedSystem ({ pkgs }: {
default = pkgs.mkShell {
# The Nix packages provided in the environment
# Add any you need here
packages = with pkgs; [
nodejs-slim_23
corepack_23
biome
deno
];

# Set any environment variables for your dev shell
env = { };

# Add any shell logic you want executed any time the environment is activated
shellHook = ''
echo "Nix dev env!"
echo "Node 🪢 version: $(node --version)"
echo "Deno 🦕 version: $(deno -V)"
'';
};
});
system = "aarch64-darwin";
pkgs = import nixpkgs { inherit system; };
in {
devShells.aarch64-darwin.default = pkgs.mkShell {
packages = with pkgs; [
biome
deno
];
shellHook = ''
echo "Nix dev env!"
echo "Deno 🦕 version: $(deno -V)"
'';
};
};
}
3 changes: 0 additions & 3 deletions package.json

This file was deleted.

10 changes: 9 additions & 1 deletion packages/resume/deno.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
{
"$schema": "https://raw.githubusercontent.com/denoland/deno/refs/heads/main/cli/schemas/config-file.v1.json",
"imports": {
"@deno/vite-plugin": "npm:@deno/vite-plugin@1.0.2",
"@suddenly-giovanni/schema-resume": "jsr:@suddenly-giovanni/schema-resume@0.0.2",
"@types/node": "npm:@types/node@22.10.10",
"effect": "npm:effect@3.12.7",
"vitest": "npm:vitest@3.0.4",
"yaml": "npm:yaml@2.7.0"
},
"tasks": {
"format": {
"description": "Format the codebase",
Expand Down Expand Up @@ -27,7 +35,7 @@
},
"test": {
"description": "Run tests",
"command": "vitest"
"command": "deno run -A --inspect npm:vitest@3.0.4 --inspect --no-file-parallelism"
}
}
}
15 changes: 0 additions & 15 deletions packages/resume/package.json

This file was deleted.

Loading
Loading