Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSR packages scope to @suddenly-giovanni/${name} #156

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

suddenlyGiovanni
Copy link
Owner

This pull request includes several changes to fix package scopes and update dependencies. The most important changes are renaming packages to follow the correct naming convention and updating the dependencies in the configuration files.

Fixes to package scopes:

  • Renamed @suddenlygiovanni/schema-resume to @suddenly-giovanni/schema-resume in packages/resume/package.json, packages/schema-resume/package.json, and packages/schema-resume/deno.json [1] [2] [3].
  • Renamed @suddenlygiovanni/resume to @suddenly-giovanni/resume in packages/resume/package.json.

Dependency updates:

  • Added imports for @changesets/cli, @types/node, @vitest/coverage-istanbul, and vitest in deno.json.
  • Removed devDependencies from package.json.

Code updates to reflect package name changes:

  • Updated imports in packages/resume/src/integration-test.spec.ts and packages/resume/src/resume.spec.ts to use the new package names [1] [2].

Renamed `@suddenlygiovanni/schema-resume` to `@suddenly-giovanni/schema-resume` across all affected files for consistency.

Signed-off-by: suddenlyGiovanni <15946771+suddenlyGiovanni@users.noreply.github.com>
Moved devDependencies from package.json to deno.json and adjusted lockfile accordingly. This improves alignment with Deno's ecosystem and simplifies configuration by consolidating dependency management.

Signed-off-by: suddenlyGiovanni <15946771+suddenlyGiovanni@users.noreply.github.com>
Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: 3a6d198

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@suddenly-giovanni/schema-resume Patch
@suddenly-giovanni/resume Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@suddenlyGiovanni suddenlyGiovanni marked this pull request as ready for review January 28, 2025 15:59
@suddenlyGiovanni suddenlyGiovanni merged commit 4c92f95 into main Jan 28, 2025
7 checks passed
@suddenlyGiovanni suddenlyGiovanni deleted the fix/jsr-name-scope branch January 28, 2025 15:59
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f44c4be). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage        ?   70.53%           
=======================================
  Files           ?       11           
  Lines           ?      112           
  Branches        ?       19           
=======================================
  Hits            ?       79           
  Misses          ?       33           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant