Skip to content

Commit

Permalink
chore(workflows): enhance PR checks with linting and type checks
Browse files Browse the repository at this point in the history
Added type checking and linting steps to the pull-request workflow for improved code quality enforcement. Removed redundant blank lines in the published workflow for better readability.

Signed-off-by: suddenlyGiovanni <15946771+suddenlyGiovanni@users.noreply.github.com>
  • Loading branch information
suddenlyGiovanni committed Jan 28, 2025
1 parent be816ec commit 1bc861e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/published.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ jobs:
- name: 📦 Setup Deno and install deps
uses: ./.github/actions/setup



- name: 📦 Publish package to JSR
shell: bash
run: |
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/pull-request-checks-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ jobs:
with:
version: latest

- name: type check
run: deno task --recursive typecheck

- name: type check docs
run: deno task --recursive typecheck --doc-only

- name: 🧬 check packages/resume code for errors (with Biome)
working-directory: ./packages/resume
run: |
Expand All @@ -41,6 +47,14 @@ jobs:
--organize-imports-enabled=false \
.
- name: deno lint code
continue-on-error: true
run: deno lint packages/**/*.ts

- name: deno lint docs
continue-on-error: true
run: deno doc --lint packages/**/*.ts

- name: 🧪 Run unit tests
run: deno task test:all --coverage

Expand Down

0 comments on commit 1bc861e

Please sign in to comment.