Generate types to deserialize simple extensions #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Rust type generation based on the YAML schema for simple extensions using typify in a new
text
module. This allows typed (de)serialization of extensions files.In addition this applies the following refactoring:
protobuf
module toproto
to better reflect the structure in the substrait main repoprotoc
feature to buildprotoc
from source in build stepThis is blocked on
substrait-io/substrait#387and substrait-io/substrait#404 (to allow the generated code to deserialize theextension_types.yaml
file). Deserialization of the extension files from the substrait submodule are tested in https://github.com/substrait-io/substrait-rs/pull/27/files#diff-f0c7b6d48022c11a573ef12664de310c63ab020e21ee0c442cb7340975663466R14.Note that this is a breaking change.