Skip to content
This repository has been archived by the owner on Jun 30, 2024. It is now read-only.

Contribute typescript-styled-plugin to provide styled intellisense #41

Merged
merged 2 commits into from
Jan 13, 2018

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Jan 12, 2018

Uses typescript-styled-plugin to add intellisense, error reporting, and other language features for styled strings

This requires VS Code 1.20+ (current insiders builds). Users on 1.19 (the current release) will only get the intellisense only if they are working in code with a jsconfig or tsconfig project

Fixes #2
Fixes #38
Fixes microsoft/typescript-styled-plugin#10

mjbvz added 2 commits January 12, 2018 14:56
Fixes styled-components#2
Fixes styled-components#38

Uses the `typescript-styled-plugin` to add intellisense, error reporting, and other language features for styled strings.

This requires VS Code 1.20+ (current insiders builds). Users on 1.19 will only get the intellisense if they are working in a jsconfig or tsconfig project
Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesss, this is great! Thank you so much! 🎉

@mxstbr mxstbr merged commit 60ac6bb into styled-components:master Jan 13, 2018
@wmertens
Copy link
Contributor

Does this work on Babel JS too?

* Detailed CSS IntelliSense while working in styled strings.
* Syntax error reporting.

> **❗Important**: IntelliSense and language support requires VS Code 1.20+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine for me in VS Code 1.19.2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Sorry. There was a leftover jsconfig.json that I didn't see.

@deadcoder0904
Copy link

So VSCode just released 1.20, so all the current builds support AutoCompletion. I just tested it & its working 🎉

@mxstbr
Copy link
Member

mxstbr commented Feb 8, 2018

Yep, this has nothing to do with using TypeScript afaik @wmertens!

@mhemrg
Copy link

mhemrg commented Apr 28, 2018

@mjbvz Great job!
I noticed that the PR doesn't work with injectGlobal.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants