Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve project analysis step #3184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve project analysis step #3184

wants to merge 1 commit into from

Conversation

dupdob
Copy link
Member

@dupdob dupdob commented Feb 5, 2025

Fix issues identified during analyis of issue #3181 :

  • skip buildanalyzer result with no defined target framework (null). It triggered an obscure exception before
  • fallbaback to project reference scan when assembly reference scan fails to identify a mutable project.

Both fixes improve tolerance in support for alternative SDKs (eg MAUI)

@dupdob dupdob force-pushed the improve_reference_solving branch from cf3fb71 to f03d3ef Compare February 5, 2025 13:01
@dupdob dupdob force-pushed the improve_reference_solving branch from f03d3ef to 058f788 Compare February 5, 2025 13:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dupdob dupdob mentioned this pull request Feb 5, 2025
Open
@slang25
Copy link

slang25 commented Feb 6, 2025

@dupdob only just spotted this, I also opened #3185 which may be relevant

@dupdob dupdob mentioned this pull request Feb 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dupdob @slang25