Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrieveUpcoming on Invoice can now take one hash as parameter #593

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

remi-stripe
Copy link
Contributor

Fixes #591

r? @ob-stripe @rattrayalex-stripe
cc @stripe/api-libraries

Copy link
Contributor

@rattrayalex-stripe rattrayalex-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my favorite way to to build query params but fine for where we are, and test coverage gives confidence.

Thanks for fixing!

@remi-stripe remi-stripe merged commit f649690 into master Apr 22, 2019
@remi-stripe remi-stripe deleted the remi-fix-upcoming branch April 22, 2019 23:46
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
retrieveUpcoming on Invoice can now take one hash as parameter
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
retrieveUpcoming on Invoice can now take one hash as parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Allow retrieveUpcoming to use only the subscription
4 participants