-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Updates #1497
API Updates #1497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, though I think we need to update
Line 28 in fe7cb12
"types": "types/2020-08-27/index.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some other usages as well:
https://github.com/stripe/stripe-node/blob/3ce7160c/README.md#L89
https://github.com/stripe/stripe-node/blob/3ce7160c/.github/ISSUE_TEMPLATE/bug_report.yml#L69
That bug_report one seems to need updating in a few other languages too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Codegen for openapi v174.
r? @dcr-stripe
cc @stripe/api-libraries
Changelog
invalid_tos_acceptance
on enumsAccount.future_requirements.errors[].code
,Account.requirements.errors[].code
,Capability.future_requirements.errors[].code
,Capability.requirements.errors[].code
,Person.future_requirements.errors[].code
, andPerson.requirements.errors[].code
shipping_cost
andshipping_details
onCheckout.Session