fix: allow detach instance profile #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Xu <xuhuan@live.cn>
mitch-hamm
approved these changes
Feb 25, 2025
ciiiii
approved these changes
Feb 25, 2025
maxsxu
pushed a commit
that referenced
this pull request
Feb 28, 2025
🤖 I have created a release *beep* *boop* --- ## [3.19.0](v3.18.0...v3.19.0) (2025-02-28) ### Features * add permissions for karpenter ([#105](#105)) ([ec3f23b](ec3f23b)) * simplify azure vendor access module ([#118](#118)) ([8f46442](8f46442)) * Support s3 table ([#111](#111)) ([55280ad](55280ad)) ### Bug Fixes * add s3tables to boundary ([#119](#119)) ([91d111d](91d111d)) * allow detach instance profile ([#117](#117)) ([ac58095](ac58095)) * reduce s3table access permission ([#120](#120)) ([29ad930](29ad930)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Karpenter need manage the instance profile directly rather than managed node groups.
The role is managed here: https://github.com/streamnative/terraform-aws-cloud/blob/master/main.tf#L435