-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bokeh package config #22
Conversation
description="Streamlit component that allows you to render Bokeh charts", | ||
long_description=long_description, | ||
long_description_content_type="text/markdown", | ||
project_urls={ | ||
"Source Code": "https://github.com/streamlit/streamlit-bokeh", | ||
"Bug Tracker": "https://github.com/streamlit/streamlit/issues", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Bug Tracker": "https://github.com/streamlit/streamlit/issues", | |
"Bug Tracker": "https://github.com/streamlit/streamlit-bokeh/issues", |
If by chance you really did intend to encourage issues go to the main library, I think we need to update the link in the README file, too.
author="Streamlit", | ||
author_email="streamlitcommunity@snowflake.com", | ||
author="Snowflake Inc", | ||
author_email="hello@streamlit.io", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is someone monitoring this email?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if relevant, but maybe still nice to add:
- add the licenses: "Apache License 2.0" -> i think this would be pretty useful
- fill in something for the
url
prop, e.g. https://streamlit.io/ or https://github.com/streamlit/streamlit-bokeh? But not sure how this is used on pypi. - Maybe provide some classifiers, but also not sure how much this is used...
Add GitHub URLs as well as copy over similar info from the Streamlit package.