Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BNB finality stuck for a few hours #7

Closed
sduchesneau opened this issue Aug 21, 2023 · 4 comments
Closed

BNB finality stuck for a few hours #7

sduchesneau opened this issue Aug 21, 2023 · 4 comments

Comments

@sduchesneau
Copy link

Finality was shown as 31045129 on RPC call:

curl -X POST "http://localhost:8545/" -H "Content-Type: application/json"  --data '{"jsonrpc":"2.0","method":"eth_getFinalizedHeader","params":[11],"id":1}'
{"jsonrpc":"2.0","id":1,"result":{"difficulty":"0x2","extraData":"0xd88301020a846765746888676f312e32302e35856c696e7578000000b19df4a2222b050441b952b350f245cc4d33b6449907cb7dc6eb9706a97d6f59bb7c529412f185e601270294a00ce0c941310258660f73ed7fea9e2baf03022cc93a571a01","gasLimit":"0x84fe2c6","gasUsed":"0xd8e658","hash":"0x10172fd8fbf710cc76edc47d0ebcfd2391e6407f5c457833b285685e40d5aff7","logsBloom":"0x1db0e7c6232054304729b5f6a17f53cf22884c56f905141a62b2034e660243139307934a559f1d856320f82f615a2363b101c93eae30220a7b7a291fa7e186e09c54c950c562d2edc5eb4c6bdda204e8befbb927426a79472817b696c1fd1c088e4d9bf3eb06b0df2cc50f447b12cf5d7d7898f851dd4fca03061114e239aed697ecc305463d75470e8525a10de18c8a94b43e777e6a37786195d9cfeaa241b6869f3905f7bd67a82f06e7cccbbb7e005124e7e98cd6177152c6e02db94636f86388d69bd66c39d7b5d0a8edca5a55e9aa190be81f506af5cbd25103e71ae82472b3ca435c2ce15c5ba7dc8144298be44bfa452868686ac91106cf3d1e317096","miner":"0xa6f79b60359f141df90a0c745125b131caaffd12","mixHash":"0x0000000000000000000000000000000000000000000000000000000000000000","nonce":"0x0000000000000000","number":"0x1d9b609","parentHash":"0x9f9dfba03df749fd9d56296d00ffe721802e6edd9da9ad0e25b5ce81ce5cfe52","receiptsRoot":"0xc7a5cea5c415805dcad49da0ab58324b70b592e24d2eeb1d611362fa4772aca4","sha3Uncles":"0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347","size":"0x28c","stateRoot":"0x7603fa86c6148e94ccc3339aa7b0d099b364b28ff05e06c0e186362375b6e823","timestamp":"0x64e3482d","totalDifficulty":"0x3ad4973","transactionsRoot":"0x3a77fb833d0ebbe5682c8545261519d1f6eb8652691d1add36b861c53b762f16"}}
(modifié)

but according to our instrumnentation, it was stuck at 31042249

FIRE END_BLOCK 31045028 31014 {"finalizedBlockHash":"0x107e2024c431aad266d0027675962f639d9a486118b2c53291430f9a7a1d7ec8","finalizedBlockNum":"0x1d9aac9"," ...

This '31042249' issue has been observed on multiple unrelated machines running bsc-v1.2.10-fh2.2

It solved itself at block 31045554

@sduchesneau
Copy link
Author

Fixed in tag bsc-v1.2.10-fh2.2-2

@sduchesneau
Copy link
Author

It seems that this happens again (few reports from Pinax and others)

@sduchesneau sduchesneau reopened this Jan 9, 2024
@sduchesneau
Copy link
Author

example here:

0034137009-7d207ab4581d763b-c4b878e229f8e968-34137006-default.dbin.zst
0034137009-d6eb576e901cca43-c4b878e229f8e968-34137007-default.dbin.zst
0034137010-039cb3ec9248b76b-d6eb576e901cca43-34137007-default.dbin.zst
0034137010-1b111828d2da7d08-7d207ab4581d763b-34137007-default.dbin.zst
0034137011-d6a759593ed7a8f5-1b111828d2da7d08-34137008-default.dbin.zst

^this is problematic because the correct path is:

  • 0034137009-7d207ab4581d763b-c4b878e229f8e968-34137006
  • 0034137010-1b111828d2da7d08-7d207ab4581d763b-34137007
  • 0034137011-d6a759593ed7a8f5-1b111828d2da7d08-34137008

we are missing the previous files to figure out the root cause. The 7009 block links to 7006, but there was probably another block that set the wrong "last final block" before that.

@sduchesneau
Copy link
Author

Fixed in https://github.com/streamingfast/go-ethereum/releases/tag/bsc-v1.3.7-fh2.2-1
The "final block num" will not be advertised anymore if the block being written by geth is not canonical.

maoueh pushed a commit that referenced this issue Apr 29, 2024
This commit squashes the op-geth fork history into a more maintainable
diff for rebasing upon upstream geth.

reference-optimistic-geth changes (origins of op-geth in early Bedrock
development stage):
- Deposit TX Type
- Enable deposit tx in EVM/tx pool
- Change deposit nonce to not be the max nonce
- Extend PayloadAttributesV1 with a Transactions field
- Force deposits at the start of each L2 block
- Fix height check
- noTxPool flag, reproduce block in verifier mode without tx pool interference
- Fix RPC json marshalling (ref op-geth PR 4)
- Deposit txs block height check in block body validation (ref op-geth PR 5)
- core: do not try to reinject deposit txs into tx-pool (ref-op-geth PR 6)
- deposit source hash field instead of L2 block height and tx index combination
- Include invalid deposits, rewind state, but always persist mint (#10)
- Provide gas to Call/Create in deposit transactions (#12)
- Add docker builds (ref-op-geth PR 16, 17)
- Don't panic on deposit transaction signature values or chain ID (ref-op-geth PR 18)
- core: Add version to DepositTx (ref-op-geth PR 19)
- Enable Geth build/lint/test in CircleCI (ref-op-geth PR 23)
- core: Include guaranteed gas in the gas pool (ref-op-geth PR 21)
- core: handle base fee, l1 availability fee, tx fee (ref-op-geth PR 27)
- fix: deposit tx hash
- fix l1 fee cache, rpc, tracing and tx pool
- core: remove deposit-tx sub-type (a.k.a. deposit version byte)
- eth/catalyst: allow engine user to reorg own chain
- miner: restore ability to reorg deep as block builder
- params: print Optimism consensus type in banner
- core/types: remove unused protected() method, see upstream PR 23376
- core: do not mutate original balance value in tx pool l1 cost adjustment
- core: subtract deposit gas from pool, so other txs do not use the same gas. And fail tx processing if deposits reach gas limit
- core/types: deposits do not tip, avoid basefee subtraction
- Unmeter the L1 Attributes Transaction
- miner: handle force tx errors as critical, clean up diff
- ci: Switch branch
- eth,miner: return STATUS_INVALID when failing to process forced transactions in request (ref-op-geth PR 40)
- verifier: forward tx to sequencer based on flag
- txpool: add flag to disable tx gossip (ref-op-geth PR 42)
- Add op-geth version in addition to geth version (ref-op-geth PR 43)
- ci: CircleCI improvements (ref-op-geth PR 44)
- Rename to op-geth
- Build latest tag on optimism branch

op-geth changes:
- Expose cache config in simulated backend (#2)
- Add EIP-1559 parameters
- eth/catalyst: update payload id computation (#1)
- make eip1559 configurable (#4)
- post-merge network should not log warnings about missing transition information (#5)
- Make the simulator more configurable (#6)
- fix OPB-6 - IsDepositTx check instead of artificial nonce value check (#7)
- Simulated backend - enable proof of stake consensus type and fix performance issue (#8)
- accounts: simulated backend consensus engine option and immediate tx indexing
- consensus/beacon: recognize all blocks as reached TTD with 0 TTD in chain config
- Add --rollup.historicalhttp CLI flag and fix backend iface
- Flags and interfaces for historical RPC requests (#12)
- Redirect historical RPC requests (#13)
- Use the pre-existing ethereum.NotFound error (ethereum#18)
- Add historical endpoint to TraceBlockByNumber and TraceBlockByHash (ethereum#19)
- Add historical endpoint to TraceTransaction (ethereum#20)
- Add historical endpoint to TraceCall (ethereum#21)
- optimism: fee params from info txi, update l1 cost func GPO params read (ethereum#15)
- add hardcoded addresses for fee payouts (ethereum#23)
- dynamic gas limit via engine API (ethereum#22)

Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Co-authored-by: Joshua Gutow <jgutow@oplabs.co>
Co-authored-by: protolambda <proto@protolambda.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: Maurelian <maurelian@protonmail.ch>
sduchesneau pushed a commit that referenced this issue Jun 14, 2024
Add piping for compiled wasm and wasm execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant