Skip to content

Commit

Permalink
Remove old TODO (ethereum#268)
Browse files Browse the repository at this point in the history
  • Loading branch information
smartcontracts authored Mar 9, 2021
1 parent 431c6fa commit b6ad0b3
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions internal/ethapi/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -1183,11 +1183,7 @@ type RPCTransaction struct {
// newRPCTransaction returns a transaction that will serialize to the RPC
// representation, with the given location metadata set (if available).
func newRPCTransaction(tx *types.Transaction, blockHash common.Hash, blockNumber uint64, index uint64) *RPCTransaction {
// TODO(mark): the transaction must be protected
var signer types.Signer = types.FrontierSigner{}
if tx.Protected() {
signer = types.NewOVMSigner(tx.ChainId())
}
var signer types.Signer = types.NewOVMSigner(tx.ChainId())
from, _ := types.Sender(signer, tx)
v, r, s := tx.RawSignatureValues()

Expand Down

0 comments on commit b6ad0b3

Please sign in to comment.