forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request ethereum#395 from maticnetwork/testing-flags
Restores linters and separate kinds of tests
- Loading branch information
Showing
19 changed files
with
409 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,80 @@ | ||
| name: CI | ||
| on: [push, pull_request] | ||
| on: | ||
| push: | ||
| branches: | ||
| - "master" | ||
| pull_request: | ||
| branches: | ||
| - "**" | ||
| types: [opened, synchronize] | ||
|
|
||
| concurrency: | ||
| group: build-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| tests: | ||
| if: (github.event.action != 'closed' || github.event.pull_request.merged == true) | ||
| strategy: | ||
| matrix: | ||
| os: [ ubuntu-20.04, macos-11 ] # list of os: https://github.com/actions/virtual-environments | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Install Go | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: 1.17 | ||
| - name: "Build binaries" | ||
| run: make all | ||
| - name: "Run tests" | ||
| run: make test | ||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v1 | ||
| with: | ||
| file: ./cover.out | ||
| - uses: actions/checkout@v3 | ||
| - run: | | ||
| git submodule update --init --recursive --force | ||
| git fetch --no-tags --prune --depth=1 origin +refs/heads/master:refs/remotes/origin/master | ||
| - uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.18.x | ||
|
|
||
| - name: Install dependencies on Linux | ||
| if: runner.os == 'Linux' | ||
| run: sudo apt update && sudo apt install build-essential | ||
|
|
||
| - name: Golang-ci install | ||
| if: runner.os == 'Linux' | ||
| run: make lintci-deps | ||
|
|
||
| - uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| ~/.cache/go-build | ||
| ~/Library/Caches/go-build | ||
| ~/go/pkg/mod | ||
| key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} | ||
| restore-keys: ${{ runner.os }}-go- | ||
|
|
||
| - name: Build | ||
| run: make all | ||
|
|
||
| # TODO: make it work | ||
|
|
||
| # - name: Reproducible build test | ||
| # run: | | ||
| # make geth | ||
| # shasum -a256 ./build/bin/geth > bor1.sha256 | ||
| # make geth | ||
| # shasum -a256 ./build/bin/geth > bor2.sha256 | ||
| # if ! cmp -s bor1.sha256 bor2.sha256; then | ||
| # echo >&2 "Reproducible build broken"; cat bor1.sha256; cat bor2.sha256; exit 1 | ||
| # fi | ||
|
|
||
| - name: Lint | ||
| if: runner.os == 'Linux' | ||
| run: make lint | ||
|
|
||
| - name: Test | ||
| run: make test | ||
|
|
||
| #- name: Data race tests | ||
| # run: make test-race | ||
|
|
||
| - name: test-integration | ||
| run: make test-integration | ||
|
|
||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v1 | ||
| with: | ||
| file: ./cover.out |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,8 @@ | |
| */**/*dapps* | ||
| build/_vendor/pkg | ||
|
|
||
| cover.out | ||
|
|
||
| #* | ||
| .#* | ||
| *# | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package leak | ||
|
|
||
| import "go.uber.org/goleak" | ||
|
|
||
| func IgnoreList() []goleak.Option { | ||
| return []goleak.Option{ | ||
| // a list of goroutne leaks that hard to fix due to external dependencies or too big refactoring needed | ||
| goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/core.(*txSenderCacher).cache"), | ||
| goleak.IgnoreTopFunction("github.com/rjeczalik/notify.(*recursiveTree).dispatch"), | ||
| goleak.IgnoreTopFunction("github.com/rjeczalik/notify.(*recursiveTree).internal"), | ||
| goleak.IgnoreTopFunction("github.com/rjeczalik/notify.(*nonrecursiveTree).dispatch"), | ||
| goleak.IgnoreTopFunction("github.com/rjeczalik/notify.(*nonrecursiveTree).internal"), | ||
| goleak.IgnoreTopFunction("github.com/rjeczalik/notify._Cfunc_CFRunLoopRun"), | ||
|
|
||
| // todo: this leaks should be fixed | ||
| goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/metrics.(*meterArbiter).tick"), | ||
| goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/consensus/ethash.(*remoteSealer).loop"), | ||
| goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/core.(*BlockChain).updateFutureBlocks"), | ||
| goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/core/state/snapshot.(*diskLayer).generate"), | ||
| goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/accounts/abi/bind/backends.nullSubscription.func1"), | ||
| goleak.IgnoreTopFunction("github.com/ethereum/go-ethereum/eth/filters.(*EventSystem).eventLoop"), | ||
| } | ||
| } |
Oops, something went wrong.