Fix #10125 - Accept falsy values returned by controllers in GraphQL queries and mutations

[gfpacheco]

What does it do?

Fix #10125

[codecov]

Codecov Report

Merging #10145 (5eada44) into master (a615f16) will increase coverage by 40.72%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #10145       +/-   ##
===========================================
+ Coverage   19.34%   60.07%   +40.72%     
===========================================
  Files         863      183      -680     
  Lines       12060     5700     -6360     
  Branches     1935     1078      -857     
===========================================
+ Hits         2333     3424     +1091     
+ Misses       8153     1815     -6338     
+ Partials     1574      461     -1113     

Flag	Coverage Δ
front	∅ <ø> (∅)
unit	60.07% <100.00%> (+20.10%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...trapi-plugin-graphql/services/resolvers-builder.js	75.00% <100.00%> (ø)
packages/strapi/lib/services/metrics/index.js	63.63% <0.00%> (-36.37%)	⬇️
...t-type-builder/controllers/validation/relations.js	50.00% <0.00%> (-12.50%)	⬇️
packages/strapi-utils/lib/logger.js	65.00% <0.00%> (-11.48%)	⬇️
...ages/strapi/lib/services/entity-validator/index.js	53.57% <0.00%> (-10.32%)	⬇️
packages/strapi/lib/services/entity-service.js	44.61% <0.00%> (-5.39%)	⬇️
packages/strapi-utils/lib/policy.js	80.00% <0.00%> (-3.64%)	⬇️
...strapi-plugin-upload/config/functions/bootstrap.js	60.00% <0.00%> (-2.07%)	⬇️
packages/strapi-plugin-upload/services/Upload.js	16.55% <0.00%> (-0.36%)	⬇️
...-builder/services/schema-builder/schema-handler.js	4.42% <0.00%> (-0.34%)	⬇️
... and 953 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225ffec...5eada44. Read the comment docs.

[alexandrebodin]

Nice improvement. Can you add some testing around that please

[gfpacheco]

@alexandrebodin can you point me in the right direction on how to do it?

It seems you use unit tests for simple functions that don't depend on strapi global, which is not the case, and I didn't see how I would mock the dependencies if I were to write unit tests for this.

The e2e tests don't have any example on changing the GraphQL schema or customize the controller action response to test for different values.

[gfpacheco]

@alexandrebodin I made the tests work using the dirtiest method possible (defining the strapi global with only the required properties): add5dd1

Let me know if there's a better way of doing it.

[alexandrebodin]

This is actually how we have to do our test for now (that global needs to go :)) That's very clear & good for me. 💯

Can you just rename it("") by test("") to follow what we usually do now :)

[alexandrebodin]

LGTM. Nice job & thank you fro your help !