Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User field string value 0 showing blank on members list export #3311

Merged

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Fixes an issue where user fields with a string value of 0 would show as blank on the members list CSV export.

How to test the changes in this Pull Request:

  1. Set up a checkbox grouped field with multiple options with only labels set (no values)
  2. Edit a user and select only the first option (which will have a value of 0)
  3. Export the members list CSV. The array( 0 ) will be join()d to string '0'. Before this PR, this would show as an empty cell in the export. After, it will correctly show as 0.

As a side note, it is highly recommended to set up the grouped checkbox field options in the format value:label to avoid values being preset to numbers which could change when options are added or removed from the field.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005 dparker1005 merged commit 66c2518 into strangerstudios:dev Mar 4, 2025
@dparker1005 dparker1005 deleted the fix-user-field-0-export branch March 4, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant