Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email template fixes to body format, variable lists and descriptions, missing variables #3301

Merged
merged 10 commits into from
Feb 14, 2025

Conversation

kimcoleman
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Improved formatting of all email body content.

Brought back email body text localization that was lost.

Removed variables from the displayed list that were duplicates of other preferred variable names.

Improved the consistency of the variable descriptions across all emails for clarity and fewer translatable strings needed.

Resolved issue in the main email class that was not returning a successful response after email send.

Adding variable for !!check_gateway_label!! so this is always pulled from the latest gateway value vs getting hard coded in the site's specific template.

Now loading check gateway instructions in the email class vs. relying on the magic that was populating this in the includes/email.php template.

Added !!refund_date!! to the user and admin refund email templates.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@dparker1005 dparker1005 merged commit 30ef202 into strangerstudios:dev Feb 14, 2025
@dparker1005 dparker1005 mentioned this pull request Feb 14, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants