Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test email variables 3166 #3294

Merged

Conversation

derekashauer
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Fixes issues from #3166
Fixes issues with test template email sending returning as "failed" in admin
Adding missing membership level data in checkout free/paid email templates
Adding missing template variable !!instructions!!

How to test the changes in this Pull Request:

  1. Go to any of the Email templates and send a test

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

  • Fixed test emails where data was empty as per Better handling of email variables in test emails #3166
  • All test emails were returning as "failed" in admin because they did not return the send() method result as the ajax response
  • Including missing membership level data in checkout free/paid email templates
  • Added missing template variable for !!instructions!! for check payments email

derekashauer and others added 7 commits February 11, 2025 15:53
…te issues

All test emails were returning as "failed" in admin because they did not return the send() method result as the ajax response

Fixed some templates missing template tags

Fixed test emails where data was empty
@dparker1005 dparker1005 merged commit 5981d7a into strangerstudios:dev Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants