Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for subscription transaction IDs up to 64 characters #3274

Merged

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Some gateways, such as Square, have subscription transaction IDs that are longer than 32 characters. This PR bumps our limit to 64 characters which matches the limit that we already have on payment transaction IDs.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005 dparker1005 added this to the 3.4 milestone Jan 29, 2025
@dparker1005 dparker1005 requested a review from ideadude January 29, 2025 18:51
Copy link
Member

@ideadude ideadude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge. Shouldn't be any issues with this DB delta.

@dparker1005 dparker1005 merged commit 3c4109b into strangerstudios:v3.4 Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants