Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Stripe Checkout always overwriting tax value #3242

Merged

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

When using Stripe Checkout, PMPro will always use the tax calculated by Stripe. This means that if a site is using the VAT Add On, the tax calculated by the Add On will be overwritten by the $0 tax calculated by Stripe.

This PR fixes that issue to only overwrite tax if Stripe is set up to calculate tax.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@andrewlimaza
Copy link
Contributor

I've retested this with the VAT Add On and it resolved the issue once marking the order as "Paid".

@dparker1005 dparker1005 merged commit 6c82675 into strangerstudios:dev Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants