Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIXING] * Rename spanish translation files to get the completed one. #3216

Merged

Conversation

MaximilianoRicoTabo
Copy link
Contributor

  • Add few remaining translations

All Submissions:

Changes proposed in this Pull Request:

Resolves an issue reported by a freescout user

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005 dparker1005 added this to the 3.4 milestone Dec 17, 2024
@dparker1005
Copy link
Member

This PR deletes the languages/paid-memberships-pro-es.mo/.po files and replaces those with languages/paid-memberships-pro-es_ES.mo/.po. I just want to confirm that we definitely want to delete the former instead of including both. @andrewlimaza Can you confirm?

@andrewlimaza
Copy link
Contributor

Digging into this a bit more, we should not delete the languages/paid-memberships-pro-es.mo/.po as this would be a fallback for Spanish locales/translation files don't exist.

For example if we do not have Spanish (Argentina) file present it would use this Spanish file generically. We should ensure that the languages/paid-memberships-pro-es.mo/.po is up to date and correct.

This may have been my bad in saying we don't actually need it, but it won't hurt since it's a fallback file for this locale. Same goes for any other locale that may have colloquial terms per country (i.e. English - UK, English - South Africa, French - Canada, French - Belgium etc).

These files can omit the location like languages/paid-memberships-pro-fr.mo/.po and languages/paid-memberships-pro-es.mo/.po. We should make sure these are up-to-date and fix it as they come through.

@andrewlimaza andrewlimaza self-requested a review January 7, 2025 07:15
@andrewlimaza
Copy link
Contributor

We shouldn't delete this file but make sure both es_ES and the es match for now and our translation server will resolve future cases once that goes out.

* Putting this file back so we can have a fallback in some cases. Our translation server should resolve these issues in the future but still good to have.
@andrewlimaza
Copy link
Contributor

@dparker1005 I've made the change by putting the es.mo/.po files back from the es_ES.mo/.po versions. It's worth to have a fallback.

@dparker1005 dparker1005 merged commit b724f58 into strangerstudios:dev Jan 8, 2025
@dparker1005 dparker1005 removed this from the 3.4 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants