Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Folks are testing sites for discount codes. We've seen over 2000-8000 attempts in a single day on our site. We'd like to track repeated failed checks as spam and so trigger spam protection after 10 failed attempts within 15 minutes (or whatever your site is set to track).
This PR only tracks checks that result in "no code found" errors as spam. It tracks every time a discount code is checked. On default setups, this is once per page load if a bad code is passed in as a parameter and once per page load when clicking on the "Apply" button from the checkout page.
If you have custom code checking the discount code numerous times, it will track numerous spam attempts.
In the future, we could perhaps update our pmpro_track_spam_activity() function avoid duplicate tracks per page load in some cases, but I think for now tracking every failed check is okay.
How to test the changes in this Pull Request:
Other information:
Changelog entry