-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-storysource: Replace loader with source-loader ✂ #7272
Changes from all commits
053aa06
d4bf622
f996f34
16d73b6
dae9e16
7ef4768
564c7d4
7b4907f
d812809
4479ae5
0ca4778
c50916e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
module.exports = require('./dist/loader'); | ||
module.exports = require('@storybook/source-loader'); | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,8 @@ | |
"regenerator-runtime": "^0.12.1" | ||
}, | ||
"peerDependencies": { | ||
"react": "*" | ||
"react": "*", | ||
"@storybook/source-loader": "*" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we will ask the developer to pull the source-loader separately There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @shilman @ndelangen should we add this line to our docs?
|
||
}, | ||
"publishConfig": { | ||
"access": "public" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
export const ADDON_ID = 'storybook/storysource'; | ||
export const ADDON_ID = 'storybook/source-loader'; | ||
export const PANEL_ID = `${ADDON_ID}/panel`; | ||
export const EVENT_ID = `${ADDON_ID}/set`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for backward compatibility, but it will be recommended to change the usage in webpack of course.