-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): #4267 upgrade lodash to latest #4284
chore(deps): #4267 upgrade lodash to latest #4284
Conversation
Update from parent repo
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As far as I remember, when we tried the es6 version last time, it broke the users' code in Storyshots, because they needed to configure jest to transpile |
Do we have a testcase in the examples that exhibits this breakage? |
I've checked it now, looks like they have a build process. And the problem we had before was with the |
Update from storybook/master
…:Stephanemw/storybook into build/4267_lodash_upgrade
Codecov Report
@@ Coverage Diff @@
## master #4284 +/- ##
==========================================
+ Coverage 39.87% 40.18% +0.31%
==========================================
Files 504 510 +6
Lines 5908 5942 +34
Branches 793 792 -1
==========================================
+ Hits 2356 2388 +32
- Misses 3168 3169 +1
- Partials 384 385 +1
Continue to review full report at Codecov.
|
Issue: Fix for #4267
What I did
Upgraded lodash to ^4.17.11, updated imports and mocks (from lodash.xxx to lodash/xxx)
How to test
yarn test --core