Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE everything (including eslint 4) #1517

Merged
merged 2 commits into from
Jul 25, 2017
Merged

Conversation

ndelangen
Copy link
Member

Issue: -packages were out of date-

eslint-config-aribnb was updated to be compatible with eslint 4 today 🎉 🎊 🎈

So I updated all packages, and fixed a small eslint error, everything seems to work locally

What I did

Updated all packages

How to test

install, bootstrap, run tests, run linting, run example

@ndelangen ndelangen self-assigned this Jul 25, 2017
@ndelangen ndelangen requested review from shilman and a team July 25, 2017 09:22
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation issues

@@ -21,16 +21,16 @@
"prepublish": "node ../../scripts/prepublish.js",
"storybook": "start-storybook -p 9001"
},
"dependencies": {
"dependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen indentation?

@codecov
Copy link

codecov bot commented Jul 25, 2017

Codecov Report

Merging #1517 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1517   +/-   ##
=======================================
  Coverage   14.61%   14.61%           
=======================================
  Files         202      202           
  Lines        4653     4653           
  Branches      507      502    -5     
=======================================
  Hits          680      680           
- Misses       3544     3546    +2     
+ Partials      429      427    -2
Impacted Files Coverage Δ
app/react/src/server/babel_config.js 44.82% <0%> (ø) ⬆️
app/react/src/client/preview/config_api.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/reducer.js 0% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.94% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
...src/server/config/WatchMissingNodeModulesPlugin.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 0% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7fb4b3...7ecb08a. Read the comment docs.

@ndelangen
Copy link
Member Author

Will merge when successful.

@ndelangen ndelangen merged commit 548a5bf into master Jul 25, 2017
@ndelangen ndelangen deleted the greenkeeper/eslint4 branch July 25, 2017 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants