-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPDATE everything (including eslint 4) #1517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation issues
addons/links/package.json
Outdated
@@ -21,16 +21,16 @@ | |||
"prepublish": "node ../../scripts/prepublish.js", | |||
"storybook": "start-storybook -p 9001" | |||
}, | |||
"dependencies": { | |||
"dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndelangen indentation?
Codecov Report
@@ Coverage Diff @@
## master #1517 +/- ##
=======================================
Coverage 14.61% 14.61%
=======================================
Files 202 202
Lines 4653 4653
Branches 507 502 -5
=======================================
Hits 680 680
- Misses 3544 3546 +2
+ Partials 429 427 -2
Continue to review full report at Codecov.
|
Will merge when successful. |
Issue: -packages were out of date-
eslint-config-aribnb was updated to be compatible with eslint 4 today 🎉 🎊 🎈
So I updated all packages, and fixed a small eslint error, everything seems to work locally
What I did
Updated all packages
How to test
install, bootstrap, run tests, run linting, run example