Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix single story hoisting at the root #13089

Merged
merged 1 commit into from
Nov 12, 2020
Merged

UI: Fix single story hoisting at the root #13089

merged 1 commit into from
Nov 12, 2020

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Nov 11, 2020

Issue: #13082

What I did

This adds support for single story hoisting at the root of the tree (where the component is an orphan). Basically all I did was add an if statement and a test case in our Storybook.

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes, added.
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@ghengeveld ghengeveld requested a review from shilman November 11, 2020 19:24
@shilman shilman changed the title Fix single story hoisting at the root UI: Fix single story hoisting at the root Nov 12, 2020
@shilman shilman merged commit b4967b9 into next Nov 12, 2020
@shilman shilman deleted the 13082-fix-no-parent branch November 12, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants