-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Instant-on manager #12707
Merged
Merged
UI: Instant-on manager #12707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cuts while loading.
shilman
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. How do we publish this as part of the release? Is that a separate PR or an addition to this one?
ndelangen
reviewed
Oct 29, 2020
ndelangen
reviewed
Oct 29, 2020
ndelangen
reviewed
Oct 29, 2020
…ss completes succesfully.
Closed
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12702
What I did
This implements an instant-on manager UI by bundling a prebuilt manager with the Storybook package, as well as caching a locally built manager. The cache gets busted whenever a change is made to
manager.js
or the webpack config (typically viamain.js
). There's also a--no-manager-cache
flag which disables caching and ignores the prebuilt manager. The prebuilt manager is also used when building a static Storybook, assuming all criteria are met.How to test
start-storybook
against a vanilla, newly installed Storybook which only hasaddon-links
andaddon-essentials
installed. It will say "Using prebuilt manager" and skip building the manager (see the startup message, it won't mention the manager build time).build-storybook
against the same Storybook, and notice it will use the prebuilt manager here as well.start-storybook
against any other Storybook. The first time it will build the manager as normal. Then kill and runstart-storybook
again. Now it will say "Using cached manager" and work the same as above.The
--no-manager-cache
flag should be added to the docs.To do