React: Add react fast refresh #12470
Conversation
fix typo
Update README.md
tooppaaa
requested review from
ndelangen,
stijnkoopal,
thomasbertet and
usulpro
as code owners
It was added here |
| @@ -0,0 +1,10 @@ | |||
| import { StorybookOptions as BaseOptions } from '@storybook/core/types'; | |||
There was a problem hiding this comment.
should this be import type? does it matter?
There was a problem hiding this comment.
I think it doesn't matter much in this case. It's just a new syntax for the same thing. It's nice when there are mixed imports (types and non-types) because it makes the code more understandable, but in that case I personally feel it doesn't make a difference
| @@ -1,4 +1,4 @@ | |||
| import type { StorybookConfig } from '@storybook/core/types'; | |||
| import type { StorybookConfig } from '@storybook/react/types'; | |||
There was a problem hiding this comment.
@hipstersmoothie is getting rid of all these separate entry points in #12462 ... i don't fully understand the rationale, but i'm wondering whether we should follow that pattern here
There was a problem hiding this comment.
I'm not sure, but wouldn't it be better if we would merge this and take care of the detail either in his PR or after that's been merged?
There was a problem hiding this comment.
CRA does not yet support import type which forces me to extract config typings in a dedicated place.
Using existing typings causes "import type" being use by storybook and react-docgen-typescript with the crashes we saw on CI (reproduced locally)
shilman
added
feature request
and removed
maintenance
|
👏 👏 👏 👏 |
Issue: #10602
What I did
Add
@pmmmwh/react-refresh-webpack-pluginandreact-refreshas part of the react preset, enabling out of the box support for fast refresh.