Addon-docs: Fix DocsPage scroll behavior #12047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
|
@yannbf can you pick this up? |
shilman
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
Hey @lisamartin00, sorry for the slow turnaround on this. Looking great, thanks so much for fixing the problem!
shilman
changed the title
|
No worries @shilman - you guys are a busy team! thanks for getting it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12042
What I did
Modified the scroll logic for first stories in the view
How to test
I believe the most appropriate way to test this is just go simply go to http://localhost:9011/?path=/docs/docs-docspage--with-subtitle and verify that the view does not scroll (as opposed to the behavior described in the issue linked above). You should also be able to click around on other stories within that group and go back and forth between the "Canvas" and "Docs" tab and have everything behave as expected.
If your answer is yes to any of these, please make sure to include it in your PR.