Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-viewports: Fix initial load state #11627

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Addon-viewports: Fix initial load state #11627

merged 2 commits into from
Oct 15, 2020
+11 −4

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 21, 2020 •
edited
Loading

Issue: #11548

What I did

  • CHANGE code to respect the existing state in useAddonState

how to test

  • load official example
  • go to /?path=/story/addons-viewport-custom-default-kindle-fire-2--overridden-via-with-viewport-parameterized-decorator

expected: the story loads in the 'ipad' viewport immediately

@ndelangen ndelangen added this to the 6.0 milestone Jul 21, 2020
@ndelangen ndelangen requested a review from shilman July 21, 2020 12:49
@ndelangen ndelangen requested a review from saponifi3d as a code owner July 21, 2020 12:49
@ndelangen ndelangen self-assigned this Jul 21, 2020
@ndelangen
Copy link
Member Author

@shilman merge and fix using global args in 6.1?

@ndelangen ndelangen mentioned this pull request Aug 3, 2020
Closed
@shilman shilman modified the milestones: 6.0, 6.0.x Aug 11, 2020
@stale
Copy link

stale bot commented Sep 2, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Sep 2, 2020
@shilman shilman changed the title FIX viewport initial load state issue Addon-viewports: Fix initial load state Sep 3, 2020
@stale stale bot removed the inactive label Sep 3, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Oct 4, 2020
@shilman shilman modified the milestones: 6.0.x, 6.1 essentials Oct 15, 2020
@stale stale bot removed the inactive label Oct 15, 2020
@shilman shilman merged commit cd53096 into next Oct 15, 2020
@shilman shilman deleted the fix/11548-initial-state branch October 15, 2020 14:19
@shilman shilman mentioned this pull request Oct 15, 2020
Closed
@gianpaj
Copy link

gianpaj commented Nov 18, 2020

Could this fix be backported to 6.0.x? or what's the process to request that?

If it's already on a todo list, which Issue/PR I can I subscribe to, to know when it's fixed on 6.0.x?

Thanks :)

@shilman
Copy link
Member

shilman commented Nov 18, 2020

@gianpaj it won't be backported. we're releasing 6.1 this week

@gianpaj
Copy link

gianpaj commented Nov 18, 2020

great! thanks so much for letting me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

@saponifi3d saponifi3d Awaiting requested review from saponifi3d

Assignees

@ndelangen ndelangen

Labels
addon: viewport bug
Projects
None yet
Milestone
6.1 essentials
Development

Successfully merging this pull request may close these issues.
3 participants
@ndelangen @gianpaj @shilman