Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix docs & essentials version on sb@next init #11303

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

tooppaaa
Copy link
Contributor

Issue: docs or essentials are installed using @latest tag instead of current version

What I did

Quick fix to resolve right value

@gaetanmaisse I think we shoudn't check the version addons in peer dependency but base them on the framework version.

@tooppaaa
Copy link
Contributor Author

@tooppaaa tooppaaa self-assigned this Jun 24, 2020
@tooppaaa tooppaaa added bug cli maintenance User-facing maintenance tasks labels Jun 24, 2020
@tooppaaa tooppaaa force-pushed the fix/cliAddonsVersion branch from fa25fce to d9a7600 Compare June 24, 2020 21:30
@tooppaaa tooppaaa removed the maintenance User-facing maintenance tasks label Jun 24, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AHA! 🤦

@shilman shilman changed the title CLI: fix docs & essentials version on @storybook/cli@next init CLI: Fix docs & essentials version on sb@next init Jun 24, 2020
@shilman shilman added this to the 6.0 essentials milestone Jun 24, 2020
@shilman shilman merged commit 111e090 into next Jun 24, 2020
@stof stof deleted the fix/cliAddonsVersion branch May 25, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants