Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Stabilize E2E tests #10888

Merged
merged 10 commits into from
May 27, 2020
Merged

CI: Stabilize E2E tests #10888

merged 10 commits into from
May 27, 2020

Conversation

tooppaaa
Copy link
Contributor

@tooppaaa tooppaaa commented May 22, 2020 •
edited
Loading

Issue: Brand new example-v2 goes wild from time to time.

What I did

  • Update story selector command
  • Update Action Story to have a button with text (cypress didn't find with emoji's..)
  • Update specs to select by buttons by text

@tooppaaa tooppaaa changed the title hacky way to fix e2e Core: Stab E2E tests May 23, 2020
@tooppaaa tooppaaa self-assigned this May 23, 2020
@tooppaaa tooppaaa added core maintenance User-facing maintenance tasks labels May 23, 2020
@tooppaaa tooppaaa marked this pull request as ready for review May 23, 2020 12:35
@tooppaaa tooppaaa requested a review from stijnkoopal as a code owner May 23, 2020 12:35
@shilman shilman changed the title Core: Stab E2E tests CI: Stabilize E2E tests May 23, 2020
@tooppaaa tooppaaa requested a review from igor-dv as a code owner May 25, 2020 09:44
@shilman
Copy link
Member

shilman commented May 25, 2020

Sorry for the merge conflicts 🙈

@tooppaaa
Copy link
Contributor Author

No worries, struggling with yarn 2 :(

@ndelangen ndelangen mentioned this pull request May 26, 2020
Merged
@ndelangen
Copy link
Member

I'm going to merge this, because it improves things.

I'm hoping @gaetanmaisse can assist in the yarn 2 issues, perhaps we should disable it in the meantime?

@ndelangen ndelangen merged commit e4cba0d into next May 27, 2020
@tooppaaa tooppaaa deleted the tech/e2eStab branch May 27, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman Awaiting requested review from shilman

@yannbf yannbf Awaiting requested review from yannbf

@gaetanmaisse gaetanmaisse Awaiting requested review from gaetanmaisse

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees

@tooppaaa tooppaaa

Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tooppaaa @shilman @ndelangen