Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocsPage: Fix controls to point to primary story #10480

Merged
merged 2 commits into from
Apr 20, 2020
Merged

DocsPage: Fix controls to point to primary story #10480

merged 2 commits into from
Apr 20, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 20, 2020 •
edited
Loading

Issue: #10478

What I did

Create a new "primary story" constant for the props table, and make it the default for the DocsPage Props controls

How to test

See updated example in official-storybook

@shilman shilman requested a review from usulpro as a code owner April 20, 2020 14:51
@shilman
Copy link
Member Author

shilman commented Apr 20, 2020

Self-merging @tmeasday

@shilman shilman requested a review from tmeasday April 20, 2020 15:39
@shilman shilman added this to the 6.0 args milestone Apr 20, 2020
@shilman shilman merged commit f5d863a into next Apr 20, 2020
@shilman shilman deleted the 10478-docspage-primary-props-controls branch April 20, 2020 15:40
@shilman shilman mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usulpro usulpro Awaiting requested review from usulpro

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
addon: docs block: props bug
Projects
None yet
Milestone
6.0 args
Development

Successfully merging this pull request may close these issues.
1 participant
@shilman