Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not execute "Storyshots Integrity" tests for imageSnapshot #3301

Closed
markelog opened this issue Mar 27, 2018 · 1 comment
Closed

Do not execute "Storyshots Integrity" tests for imageSnapshot #3301

markelog opened this issue Mar 27, 2018 · 1 comment
Assignees
@thomasbertet
Labels
addon: storyshots feature request

Comments

@markelog
Copy link
Contributor

markelog commented Mar 27, 2018 •
edited
Loading

Bug or support request summary

In the StoryShots add-on context.

If imageSnapshot test is used it will also executes default Storyshots Integrity suite, which might take quite a bit of time –

screen shot 2018-03-27 at 14 48 48

Please specify which version of Storybook and optionally any affected addons that you're running

  • storybook/react@3.2.12
  • storybook/addon-storyshots@3.4.0-rc.3

Acceptance criteria

Do not execute Storyshots Integrity for imageSnapshot variation of the test, since that type of testing does not generates snapshot files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasbertet thomasbertet

Labels
addon: storyshots feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@markelog @danielduan @thomasbertet @Hypnosphi