Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of addon-storyshots with angular-cli project #3290

Closed
x1c0 opened this issue Mar 26, 2018 · 8 comments
Closed

Integration of addon-storyshots with angular-cli project #3290

x1c0 opened this issue Mar 26, 2018 · 8 comments

Comments

@x1c0
Copy link
Contributor

x1c0 commented Mar 26, 2018

I'm trying to integrate addon-storyshots in an angular-cli project but I can't make it work.
I setup a new angular-cli project, I integrated with storybook and added the storyshots addon to serve as playground.

Steps to reproduce

  1. clone/download my repo -> https://github.com/x1c0/angular-storybook-jest
  2. Run npm run storybook on one terminal.
  3. Run npm run jest on another terminal.

The snapshots are not being captured, should they be? Am I missing any configuration? I followed all the addon documentation steps.

Running the npm run jest just hangs here, no error:
image

Please specify which version of Storybook and optionally any affected addons that you're running

  • storybook/angular: "^3.4.0-rc.3",
  • storybook/addon-notes: "^3.4.0-rc.3",
  • storybook/addon-actions: "^3.4.0-rc.3",
  • storybook/addon-links: "^3.4.0-rc.3",
  • storybook/addons: "^3.4.0-rc.3",
  • storybook/addon-storyshots: "^3.4.0-rc.3",

Affected platforms

Mac OS

@igor-dv
Copy link
Member

igor-dv commented Apr 4, 2018

Will check it today

@igor-dv
Copy link
Member

igor-dv commented Apr 4, 2018

I've managed to make it work with multiSnapshots:

import initStoryshots, { multiSnapshotWithOptions } from '@storybook/addon-storyshots';

initStoryshots({
    test: multiSnapshotWithOptions({}),
});

Also, there is a problem with the inner Integrity Test, that takes too much time (#3301). I think I will remove them as a temporary solution.

@Hypnosphi
Copy link
Member

Integrity fix released as 4.0.0-alpha.3

@igor-dv
Copy link
Member

igor-dv commented Apr 18, 2018

@Hypnosphi can't we release it as a patch for 3.4 as well ?

@Hypnosphi
Copy link
Member

Looks we've actually released it as 3.4 but it didn't get into changelog

cc @shilman

@stale
Copy link

stale bot commented May 9, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 9, 2018
@Hypnosphi
Copy link
Member

Now released as 3.4.4

@stale stale bot removed the inactive label May 12, 2018
@stale
Copy link

stale bot commented Jun 2, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants