Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: quote readlink to fix windows make check #1197

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Fix: quote readlink to fix windows make check #1197

merged 1 commit into from
Mar 5, 2025

Conversation

ecstrema
Copy link
Contributor

@ecstrema ecstrema commented Mar 5, 2025 •
edited
Loading

@readlink -f ${SHELL} means @readlink -f C:\Program Files\Git\usr\bin\sh.exe on windows, so we need to escape the path to account for the space

@ecstrema
Fix: quote readlink to fix windows make check
32d40b1 
@readlink -f ${SHELL} means @readlink -f C:\Program Files\Git\usr\bin\sh.exe on windows, so we need to escape the path to account for the space

Signed-off-by: Rémi Marche <35939574+ecstrema@users.noreply.github.com>
@stnolting stnolting added bug Something isn't working as expected SW Software-related labels Mar 5, 2025
@stnolting
Copy link
Owner

Thanks for fixing!

@stnolting stnolting merged commit fa0ea69 into stnolting:main Mar 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnolting stnolting stnolting approved these changes

Assignees
No one assigned
Labels
bug Something isn't working as expected SW Software-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecstrema @stnolting