feat(ssr): add angular 19 SSR support #337
Closed
+13
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hizliemre
commented
Jan 26, 2025
hizliemre
commented
- Deleted REQUEST injection token
- Moved the constructor injections to inject functions
- Added some extra controls to prevent break the code
- Fixes Support For AngularNodeAppEngine #335
hizliemre
changed the title
|
|
@stevermeister Could you please review my PR? |
pavankjadda
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
projects/ngx-cookie-service-ssr/src/lib/ssr-cookie.service.ts:79
- The variable 'result' should have a type annotation for clarity. It should be annotated as 'RegExpExecArray | null'.
const result = regExp.exec(cookieString ?? '');
|
#338 will take care of this |
|
That was fast! I just noticed a notification :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.