fix typo, add back missing constructor in config_provider_test

Signed-off-by: Xin Zhuang <stevenzzz@google.com>
stevenzzzz · Aug 1, 2019 · 46ad9af · 46ad9af
1 parent ee09a5b
commit 46ad9af
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/source/common/router/scoped_rds.cc b/source/common/router/scoped_rds.cc
@@ -117,7 +117,7 @@ void ScopedRdsConfigSubscription::onConfigUpdate(
   rds.mutable_config_source()->MergeFrom(rds_config_source_);
 
   // If new route config sources come after the factory_context_.initManager()'s initialize() been
-  // called, that initManager can't accepct new targets. Instead we use a local override which will
+  // called, that initManager can't accept new targets. Instead we use a local override which will
   // start new subscriptions but not wait on them to be ready (to not block on main thread).
   std::unique_ptr<Init::ManagerImpl> overriding_init_manager;
   if (factory_context_.initManager().state() == Init::Manager::State::Initialized) {

diff --git a/test/common/config/config_provider_impl_test.cc b/test/common/config/config_provider_impl_test.cc
@@ -21,6 +21,7 @@ class DummyConfigProviderManager;
 
 class DummyConfig : public Envoy::Config::ConfigProvider::Config {
 public:
+  DummyConfig() {}
   explicit DummyConfig(const test::common::config::DummyConfig& config_proto) {
     protos_.push_back(config_proto);
   }

diff --git a/test/mocks/router/mocks.cc b/test/mocks/router/mocks.cc
@@ -126,6 +126,7 @@ MockRouteConfigProviderManager::~MockRouteConfigProviderManager() {}
 MockScopedConfig::MockScopedConfig() {
   ON_CALL(*this, getRouteConfig(_)).WillByDefault(Return(route_config_));
 }
+MockScopedConfig::~MockScopedConfig() = default;
 
 MockScopedRouteConfigProvider::MockScopedRouteConfigProvider()
     : config_(std::make_shared<MockScopedConfig>()) {