Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-182: Removing string replace from registries and changing hardc… #184

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Issue-182: Removing string replace from registries and changing hardc… #184

merged 1 commit into from
Jan 4, 2017

Conversation

dlemures
Copy link
Collaborator

@dlemures dlemures commented Jan 3, 2017

…oded string inside switch block instead

Issue: #182

@dlemures dlemures added this to the 1.0.4 milestone Jan 3, 2017
@dlemures dlemures mentioned this pull request Jan 3, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 94.866% when pulling 7c81828 on dlemures/issue-182 into 15b56fe on master.

@stephanenicolas
Copy link
Owner

image

@dlemures dlemures force-pushed the dlemures/issue-182 branch 2 times, most recently from ad96fb8 to 9bbc804 Compare January 4, 2017 12:53
@dlemures
Copy link
Collaborator Author

dlemures commented Jan 4, 2017

Adding extra test to check registries working at runtime for nested classes.

@dlemures dlemures force-pushed the dlemures/issue-182 branch 2 times, most recently from 40e9852 to cda67bb Compare January 4, 2017 13:46
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 94.629% when pulling cda67bb on dlemures/issue-182 into 6b3153f on master.

@dlemures dlemures merged commit b59ede5 into master Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanenicolas stephanenicolas Awaiting requested review from stephanenicolas

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@dlemures @coveralls @stephanenicolas