Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 12 actions are deprecated #246

Closed
SevereCloud opened this issue Oct 10, 2022 · 4 comments
Closed

Node.js 12 actions are deprecated #246

SevereCloud opened this issue Oct 10, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@SevereCloud
Copy link

git-auto-commit Version

v4.15.0

Machine Type

Ubuntu (eg. ubuntu-latest)

Bug description

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: stefanzweifel/git-auto-commit-action

Steps to reproduce

Run and see annotations

Tried solutions

No response

Example Workflow

-

Relevant log output

No response

@SevereCloud SevereCloud added the bug Something isn't working label Oct 10, 2022
@stefanzweifel
Copy link
Owner

Thanks for bringing this up. Will push an update in the next few hours.

stefanzweifel added a commit that referenced this issue Oct 10, 2022
@stefanzweifel
Copy link
Owner

Fixed in v4.15.1: https://github.com/stefanzweifel/git-auto-commit-action/releases/tag/v4.15.1

@lukasz-mitka
Copy link

lukasz-mitka commented Oct 17, 2022

@stefanzweifel I advice doing a major release instead and pointing v4 tag back to v4.15.0
Node upgrade can brake this action for GHES that haven't upgraded yet.

@stefanzweifel
Copy link
Owner

@lukasz-mitka I thought about doing that. Decided against it, as this Action uses node.js only to execute the shell script: https://github.com/stefanzweifel/git-auto-commit-action/blob/master/index.js#L27

By releasing a new major version, thousands of workflows also have to be updated. Dependabot sometimes takes care of this, but not always (?).
Not sure if it's worth the trouble. 🤔

I guess you run GHES and run into this issue?
Maybe I could also point v4 back to v4.15.0 and wait a month or so, until the majority of GHES users have updated?
(I have no clue how GHES works)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants