Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blas/base/wasm/isamax #3984

Merged
merged 8 commits into from
Feb 8, 2025
Merged

feat: add blas/base/wasm/isamax #3984

merged 8 commits into from
Feb 8, 2025

Conversation

aman-095
Copy link
Member

Progresses #2039

Description

What is the purpose of this pull request?

This pull request adds wasm support for isamax.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Dec 17, 2024
@aman-095 aman-095 added Feature Issue or pull request for adding a new feature. WebAssembly Issue involves or relates to WebAssembly. labels Dec 17, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 17, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/base/wasm/isamax $\color{green}557/557$
$\color{green}+100.00\%$ 		$\color{green}17/17$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}557/557$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Feb 6, 2025

@aman-095 Given the recent migration to blas/base/wasm, would you mind moving and renaming this package accordingly?

@aman-095
Copy link
Member Author

aman-095 commented Feb 7, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 7, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 7, 2025
aman-095 and others added 2 commits February 7, 2025 17:15
@aman-095
refactor: update path and name
96684a1 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@aman-095
Update main.wat
ce89c6a 
Signed-off-by: Aman Bhansali <92033532+aman-095@users.noreply.github.com>
@aman-095 aman-095 changed the title feat: add wasm support for blas/base/isamax-wasm feat: add wasm support for blas/base/wasm/isamax Feb 7, 2025
@aman-095 aman-095 marked this pull request as ready for review February 7, 2025 12:06
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 7, 2025
@aman-095 aman-095 removed the Needs Review A pull request which needs code review. label Feb 7, 2025
@kgryte kgryte changed the title feat: add wasm support for blas/base/wasm/isamax feat: add blas/base/wasm/isamax Feb 8, 2025
@kgryte kgryte self-requested a review February 8, 2025 07:25
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 8, 2025
@kgryte
bench: update assertions
a87a091 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Feb 8, 2025
kgryte
kgryte approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit cd30ae4 into stdlib-js:develop Feb 8, 2025
13 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
@aman-095 @kgryte
@stdlib-bot @saurabhraghuvanshii
feat: add blas/base/wasm/isamax
5b881f9 
PR-URL: stdlib-js#3984
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Co-authored-by: stdlib-bot <noreply@stdlib.io>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@aman-095 @kgryte
@stdlib-bot @ShabiShett07
feat: add blas/base/wasm/isamax
6bbedfa 
PR-URL: stdlib-js#3984
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. WebAssembly Issue involves or relates to WebAssembly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman-095 @stdlib-bot @kgryte