fix: enable pxclient and filter peerExchange peers returned #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (60)
|
chaitanyaprem
force-pushed
the
fix/enable-pxclient
branch
from
03dea63 to
e9e82e3
Compare
1 task
chaitanyaprem
force-pushed
the
fix/enable-pxclient
branch
from
be0bd60 to
dca196a
Compare
|
I think the commit history got messed up, @chaitanyaprem! |
Ah, noticing only now. Thanks, will fix it. |
chaitanyaprem
force-pushed
the
fix/enable-pxclient
branch
2 times, most recently
from
d8e41c3 to
7b18573
Compare
richard-ramos
approved these changes
Jun 18, 2024
kaichaosun
reviewed
Jun 19, 2024
vendor/github.com/waku-org/go-waku/waku/v2/peermanager/peer_manager.go
Show resolved
Hide resolved
This was referenced Jun 24, 2024
chaitanyaprem
force-pushed
the
fix/enable-pxclient
branch
from
1e6b8ec to
17c0715
Compare
kaichaosun
approved these changes
Jun 25, 2024
chaitanyaprem
force-pushed
the
fix/enable-pxclient
branch
3 times, most recently
from
7e93675 to
080cf4a
Compare
chaitanyaprem
force-pushed
the
fix/enable-pxclient
branch
from
5e1a204 to
080cf4a
Compare
chaitanyaprem
force-pushed
the
fix/enable-pxclient
branch
from
080cf4a to
4fec6c5
Compare
|
Merging this PR since got go-ahead from QA and waku team dogfooding. Reference discussion https://discord.com/channels/1110799176264056863/1255090529365131296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to disable peerExchange client in #4665 as e2e tests were failing when it is enabled.
But while debugging another issue, had noticed that we are not filtering the peers returned via peerExchange based on cluster and shards. This could mean we could be trying to connecting to peers outside cluster 16.
A description to understand introduced changes without reading the code.
Important changes:
added logic to filter based on DefaultShard (32) and cluster 16 as it is expected that all nodes for status waku network shall support shard 32 by default.
Re-enabled peerExchange client so that non fleet peers are also connected to
Few additional fixes identified in go-waku to handle some scenarios noticed while debugging peer-connectivity should also be included.
Fixes #5344
Note that due to connectivity issues, it takes about 30-45 seconds for all filter subscriptions to happen after start of node. That should get addressed as part of some of go-waku PRs above and dogfooding.